Skip to content

Lint with deno 1.33#557

Merged
mxcl merged 1 commit into
mainfrom
v0.31
Apr 29, 2023
Merged

Lint with deno 1.33#557
mxcl merged 1 commit into
mainfrom
v0.31

Conversation

@mxcl
Copy link
Copy Markdown
Contributor

@mxcl mxcl commented Apr 28, 2023

No description provided.

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Apr 28, 2023 •
edited
Loading

PR Summary

  • Update version number in README
    The version number displayed in the README file will be updated.

  • Fix type errors caused by Deno API changes
    This change resolves type errors that occurred due to changes in the Deno API. See the related discussion here: denoland/deno_std#1299.

  • Add test for tea run with no arguments
    A new test is added to verify that when tea run is executed without any arguments, it will fail gracefully instead of throwing an error.

  • Remove problematic code from tests
    Unnecessary code causing test failures on Windows and MacOSX platforms due to symlink handling differences will be removed, improving compatibility across operating systems.

@mxcl mxcl force-pushed the v0.31 branch 3 times, most recently from 121b6db to febbc9f Compare April 28, 2023 16:45
@mxcl mxcl requested a review from ABevier April 28, 2023 16:48
@mxcl mxcl force-pushed the v0.31 branch 2 times, most recently from c84cd4e to 9735d55 Compare April 28, 2023 17:30
ABevier
ABevier approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ABevier ABevier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢
This looks good once you get passing tests. It's a shame that the deno api is changing like this :-(

@mxcl mxcl merged commit 12c9669 into main Apr 29, 2023
@mxcl mxcl deleted the v0.31 branch April 29, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ABevier ABevier ABevier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mxcl @ABevier